Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kms): support the EKM service #8530

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 10, 2022

This is a new gRPC service in the same googleapis directory (google/cloud/kms/v1) so it goes into the same library.

Fixes #8483.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: cloudkms Issues related to the Cloud Key Management Service API. label Mar 10, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 25451910c1cecbb03c7a8ea1961a092f303c548b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8530 (8dc851a) into main (70e0a81) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8530      +/-   ##
==========================================
- Coverage   93.92%   93.92%   -0.01%     
==========================================
  Files        1453     1453              
  Lines      125889   125889              
==========================================
- Hits       118242   118241       -1     
- Misses       7647     7648       +1     
Impacted Files Coverage Δ
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e0a81...8dc851a. Read the comment docs.

@dbolduc
Copy link
Member

dbolduc commented Mar 10, 2022

  1. I think we want a note somewhere in the CHANGELOG that this service has been added. Like we did in cleanup: touch up CHANGELOG #8422 for bigquery
  2. Can you add the new environment variable here:
    - `GOOGLE_CLOUD_CPP_KEY_MANAGEMENT_SERVICE_ENDPOINT=...` changes the default endpoint
    (cloudkms.googleapis.com) used by `KeyManagementServiceConnection`.

This makes me think we may want/need a section in our howto doc for "adding new services to GA libraries". Even if it's just a two item checklist. What do you think?

@coryan coryan force-pushed the feat-kms-support-ekm-service branch from 2545191 to 8dc851a Compare March 10, 2022 18:18
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8dc851a0578d16336174cdd00b1a279799891eaa

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review March 10, 2022 19:10
@coryan coryan requested a review from a team as a code owner March 10, 2022 19:10
@coryan coryan merged commit 8e39dd5 into googleapis:main Mar 10, 2022
@coryan coryan deleted the feat-kms-support-ekm-service branch March 10, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudkms Issues related to the Cloud Key Management Service API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ekm_service.proto for google/cloud/kms
3 participants