-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kms): support the EKM service #8530
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8530 +/- ##
==========================================
- Coverage 93.92% 93.92% -0.01%
==========================================
Files 1453 1453
Lines 125889 125889
==========================================
- Hits 118242 118241 -1
- Misses 7647 7648 +1
Continue to review full report at Codecov.
|
This makes me think we may want/need a section in our howto doc for "adding new services to GA libraries". Even if it's just a two item checklist. What do you think? |
2545191
to
8dc851a
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This is a new gRPC service in the same googleapis directory (
google/cloud/kms/v1
) so it goes into the same library.Fixes #8483.
This change is