fix(spanner): correct handling of PartialResultSet.resume_token #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems: - A `google::spanner::v1::PartialResultSet` will not contain a `resume_token` when it also does not complete a new row, so `last_resume_token_` should not be updated in that case. - When `PartialResultSetResume::Read()` uses its factory and `last_resume_token_` to create a new `PartialResultSetReader`, it should inform the `PartialResultSetSource` so that any partly-constructed row can be discarded before processing the resumed stream (which will resend that row). That is, a "resume token" is really a row iterator, and a level above row fragmentation and value chunking. So fix all of that. Then expand the `ConnectionImplTest.ReadSuccess` test case to exercise the new code paths.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8521 +/- ##
==========================================
- Coverage 93.92% 93.92% -0.01%
==========================================
Files 1452 1452
Lines 125854 125883 +29
==========================================
+ Hits 118211 118235 +24
- Misses 7643 7648 +5
Continue to review full report at Codecov.
|
coryan
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
google::spanner::v1::PartialResultSetmay not containa
resume_tokenwhen it also does not complete a new row,so
last_resume_token_should not be updated in that case.PartialResultSetResume::Read()uses its factory andlast_resume_token_to create a newPartialResultSetReader,it should inform the
PartialResultSetSourceso that anypartly-constructed row can be discarded before processing
the resumed stream (which will resend that row).
That is, a "resume token" is really a row iterator, and a level
above row fragmentation and value chunking. So fix all of that.
Then expand the
ConnectionImplTest.ReadSuccesstest case toexercise the new code paths.
This change is