Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): instantiate OptionsSpan objects in legacy admin calls #8440

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix(spanner): instantiate OptionsSpan objects in legacy admin calls #8440

merged 1 commit into from
Feb 23, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Feb 23, 2022 •
edited by coryan
Loading

This doesn't change the legacy Spanner database/instance admin APIs at
all, but it does ensure that the connection options have been installed
in an OptionsSpan over calls into the library.

Fixes #8438 and #8439.

This change is Reviewable

@devbww
fix(spanner): instantiate OptionsSpan objects in legacy admin calls
a57cbd4 
This doesn't change the legacy Spanner database/instance admin APIs at
all, but it does ensure that the connection options have been installed
in an `OptionsSpan` over calls into the library.

Fixes googleapis#8438 and googleapis#8439.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Feb 23, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a57cbd46c689413b7a99607d6b2ec2138883e733

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #8440 (a57cbd4) into main (1e165e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8440   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files        1366     1368    +2     
  Lines      122339   122405   +66     
=======================================
+ Hits       116335   116404   +69     
+ Misses       6004     6001    -3
Impacted Files Coverage Δ
google/cloud/spanner/database_admin_client.cc 99.31% <100.00%> (+0.24%) ⬆️
google/cloud/spanner/database_admin_connection.cc 85.71% <100.00%> (+0.08%) ⬆️
google/cloud/spanner/database_admin_connection.h 100.00% <100.00%> (ø)
google/cloud/spanner/instance_admin_client.cc 100.00% <100.00%> (ø)
google/cloud/spanner/instance_admin_connection.cc 91.97% <100.00%> (+0.10%) ⬆️
google/cloud/spanner/instance_admin_connection.h 100.00% <100.00%> (ø)
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e165e8...a57cbd4. Read the comment docs.

@devbww devbww marked this pull request as ready for review February 23, 2022 06:34
@devbww devbww requested a review from a team as a code owner February 23, 2022 06:34
@devbww devbww enabled auto-merge (squash) February 23, 2022 06:57
@devbww devbww merged commit 8788590 into googleapis:main Feb 23, 2022
@devbww devbww deleted the spanner-legacy-admin-options-span branch February 23, 2022 17:15
@devbww devbww mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner database admin client (legacy) OptionsSpan
3 participants
@devbww @google-cloud-cpp-bot @coryan