-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): use original options when resuming streaming RPCs #8404
fix(common): use original options when resuming streaming RPCs #8404
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8404 +/- ##
==========================================
- Coverage 95.04% 95.03% -0.01%
==========================================
Files 1363 1363
Lines 121304 121328 +24
==========================================
+ Hits 115290 115306 +16
- Misses 6014 6022 +8
Continue to review full report at Codecov.
|
6d43ca3
to
f74c2af
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about
google::cloud::internal::ResumableStreamingReadRpc<>
, I just created #8404, you can tell me there if the changes are not needed.
No, I don't think these changes are needed. That is, these new OptionsSpans
are redundant, and we probably should avoid creating them, if only for performance reasons. It is also nice to have the span stuff all in one place, and as close to the user as possible.
In this case, a ResumableStreamingReadRpc
is always immediately transferred into a StreamReader<T>
functor, and that is then moved into a StreamRange<T>
via MakeStreamRange<T>()
. From there, the reader is only ever invoked/destroyed under the restored options, as the user handles the StreamRange<T>
, due to the changes already made to google/cloud/stream_range.h
.
Thanks for looking into it. |
From the discussion on #8355 (comment)
This change is