fix: restore Options over deletion of StreamRange<T>::reader_ #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the creation-time `Options` in the `StreamRange<T>` destructor while explicitly clearing the `reader_` functor. If the reader has not reached the end of the range, then deleting it may send a best-effort, out-of-band cancel on the call, and we should restore the options when re-entering the library. Add a test for the destructor case. This is a followup to googleapis#8256. Also take this opportunity to delete some unused type aliases I stumbled upon during this work.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8403 +/- ##
==========================================
- Coverage 95.09% 95.08% -0.02%
==========================================
Files 1360 1360
Lines 121124 121150 +26
==========================================
+ Hits 115185 115196 +11
- Misses 5939 5954 +15
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 17, 2022
coryan
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the creation-time
Optionsin theStreamRange<T>destructorwhile explicitly clearing the
reader_functor. If the reader has notreached the end of the range, then deleting it may send a best-effort,
out-of-band cancel on the call, and we should restore the options when
re-entering the library. Add a test for the destructor case. This is
a followup to #8256.
Also take this opportunity to delete some unused type aliases I stumbled
upon during this work.
This change is