Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): workaround MSVC limits #8357

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 12, 2022

I have a different version of MSVC compared to the version used in CI.
The tests do not compile without /bigobj, and presumably this affects
customers too. We probably should enable that option for all tests.


This change is Reviewable

I have a different version of MSVC compared to the version used in CI.
The tests do not compile without `/bigobj`, and presumably this affects
customers too.  We probably should enable that option for all tests.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 12, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 291d011fc2c23b9997586a1b72dc0b99fc661d49

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #8357 (291d011) into main (5f0c674) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8357   +/-   ##
=======================================
  Coverage   94.98%   94.99%           
=======================================
  Files        1360     1360           
  Lines      121062   121062           
=======================================
+ Hits       114996   114997    +1     
+ Misses       6066     6065    -1     
Impacted Files Coverage Δ
google/cloud/bigtable/internal/common_client.h 94.02% <0.00%> (-5.98%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
google/cloud/completion_queue_test.cc 97.14% <0.00%> (+0.19%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.25% <0.00%> (+0.49%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 97.91% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0c674...291d011. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 12, 2022 02:20
@coryan coryan requested a review from a team as a code owner February 12, 2022 02:20
@coryan coryan enabled auto-merge (squash) February 12, 2022 02:20
@coryan coryan merged commit 18082df into googleapis:main Feb 12, 2022
@coryan coryan deleted the test-storage-workaround-MSVC-limits branch February 12, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants