Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pubsub): add region tag for subscription with filter #8326

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 9, 2022

Use the existing example, it does what we want it just needed the right
region tags.


This change is Reviewable

Use the existing example, it does what we want it just needed the right
region tags.
@snippet-bot
Copy link

snippet-bot bot commented Feb 9, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 9, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: fbeb2e4f4360d8ab88b8cf3321882891ebb04ac5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #8326 (fbeb2e4) into main (79e9bdf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8326   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files        1345     1345           
  Lines      119817   119817           
=======================================
  Hits       113794   113794           
  Misses       6023     6023           
Impacted Files Coverage Δ
google/cloud/pubsub/samples/samples.cc 92.10% <ø> (-0.16%) ⬇️
google/cloud/internal/async_rpc_details.h 94.44% <0.00%> (-5.56%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.04% <0.00%> (-0.71%) ⬇️
google/cloud/completion_queue_test.cc 96.95% <0.00%> (-0.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
google/cloud/storage/internal/curl_handle.cc 73.03% <0.00%> (+0.56%) ⬆️
google/cloud/bigtable/internal/common_client.h 100.00% <0.00%> (+5.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e9bdf...fbeb2e4. Read the comment docs.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "_subscrption_wit_" in the title intentional?

@coryan coryan changed the title doc(pubsub): add pubsub_create_subscrption_wit_filter doc(pubsub): add region tag for subscription with filter Feb 10, 2022
@coryan
Copy link
Contributor Author

coryan commented Feb 10, 2022

is "subscrption_wit" in the title intentional?

Thanks, fixed.

@coryan coryan marked this pull request as ready for review February 10, 2022 00:41
@coryan coryan requested a review from a team as a code owner February 10, 2022 00:41
@coryan coryan enabled auto-merge (squash) February 10, 2022 00:41
@coryan
Copy link
Contributor Author

coryan commented Feb 10, 2022

/cc: @anguillanneuf

@coryan coryan merged commit 654e6eb into googleapis:main Feb 10, 2022
@coryan coryan deleted the doc-pubsub-create-subscription-with-filter branch February 10, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants