feat(common): include the request/response type name in the RPC log #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7782 +/- ##
==========================================
- Coverage 95.15% 95.15% -0.01%
==========================================
Files 1278 1278
Lines 115078 115080 +2
==========================================
- Hits 109502 109501 -1
- Misses 5576 5579 +3
Continue to review full report at Codecov.
|
coryan
approved these changes
Dec 23, 2021
| @@ -60,6 +60,7 @@ TEST(LogWrapper, DefaultOptions) { | |||
| TracingOptions tracing_options; | |||
| // clang-format off | |||
| std::string const text = | |||
| R"pb(google.spanner.v1.Mutation { )pb" | |||
There was a problem hiding this comment.
Feels like this could be a single raw string, maybe for another PR.
There was a problem hiding this comment.
I think the lack of newlines dooms this to being some form of concatenation.
| @@ -118,7 +121,9 @@ TEST(LogWrapper, Truncate) { | |||
| TracingOptions tracing_options; | |||
| tracing_options.SetOptions("truncate_string_field_longer_than=8"); | |||
| // clang-format off | |||
| std::string const text =R"pb(insert { )pb" | |||
| std::string const text = | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is