-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): Change AsyncReadWriteStreamAuth to be usable with unique_ptr #7692
fix(pubsub): Change AsyncReadWriteStreamAuth to be usable with unique_ptr #7692
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7692 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 1254 1254
Lines 113589 113617 +28
=======================================
+ Hits 108241 108276 +35
+ Misses 5348 5341 -7
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the robots are still unhappy.
…_ptr Also fix a bug where if it was cancelled while auth was being set up, neither the spawning context nor the created stream would be cancelled.
80edd64
to
2a8570d
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Also fix a bug where if it was cancelled while auth was being set up, neither the spawning context nor the created stream would be cancelled.
This change is