Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): Change AsyncReadWriteStreamAuth to be usable with unique_ptr #7692

Merged
merged 4 commits into from
Dec 7, 2021

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Dec 3, 2021

Also fix a bug where if it was cancelled while auth was being set up, neither the spawning context nor the created stream would be cancelled.


This change is Reviewable

@dpcollins-google dpcollins-google requested a review from a team as a code owner December 3, 2021 15:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Dec 3, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 76ae62fc98f7d8228b453c85b480e078d8a0d9d3

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7692 (1f84b47) into main (6557aba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7692   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files        1254     1254           
  Lines      113589   113617   +28     
=======================================
+ Hits       108241   108276   +35     
+ Misses       5348     5341    -7     
Impacted Files Coverage Δ
google/cloud/pubsub/internal/subscriber_auth.h 100.00% <ø> (ø)
google/cloud/pubsub/internal/subscriber_logging.h 100.00% <ø> (ø)
...oogle/cloud/pubsub/internal/subscriber_metadata.cc 100.00% <ø> (ø)
...le/cloud/pubsub/internal/subscriber_round_robin.cc 100.00% <ø> (ø)
...gle/cloud/pubsub/internal/subscriber_round_robin.h 100.00% <ø> (ø)
google/cloud/pubsub/internal/subscriber_stub.h 100.00% <ø> (ø)
...ogle/cloud/internal/async_read_write_stream_auth.h 97.91% <100.00%> (+6.48%) ⬆️
...loud/internal/async_read_write_stream_auth_test.cc 97.14% <100.00%> (ø)
...ternal/streaming_subscription_batch_source_test.cc 99.23% <100.00%> (ø)
google/cloud/pubsub/internal/subscriber_auth.cc 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6557aba...1f84b47. Read the comment docs.

coryan
coryan previously requested changes Dec 3, 2021
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
google/cloud/internal/async_read_write_stream_auth.h Outdated Show resolved Hide resolved
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 80edd6467b9381d6fa643630897a0731b927affa

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the robots are still unhappy.

…_ptr

Also fix a bug where if it was cancelled while auth was being set up, neither the spawning context nor the created stream would be cancelled.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 2a8570d8a2e5cef85356f3f54da33f5eb3573167

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dpcollins-google dpcollins-google added the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 1f84b47b43800d89ab0c25282eb61597212a5aab

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2021
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@coryan coryan merged commit 96a91e0 into googleapis:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants