feat(generator): more stable googleapis proto links #7606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to minimize the number of changes when we change the commit SHA for googleapis/googleapis. With this change we use a Doxygen custom command in the header files. The CMake file defines this command to include the embedded SHA. The arguments to the command *should* be more stable, but will change when proto definitions are moved in their `.proto` file.
google-cla
bot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7606 +/- ##
=======================================
Coverage 95.24% 95.25%
=======================================
Files 1254 1254
Lines 113178 113148 -30
=======================================
- Hits 107802 107775 -27
+ Misses 5376 5373 -3
Continue to review full report at Codecov.
|
scotthart
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to minimize the number of changes when we change the commit SHA
for googleapis/googleapis. With this change we use a Doxygen custom
command in the header files. The CMake file defines this command to
include the embedded SHA. The arguments to the command should be more
stable, but will change when proto definitions are moved in their
.protofile.This change is