Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: substitute build metadata (git commit) in bazel builds #7378

Merged
merged 2 commits into from
Sep 30, 2021
Merged

fix: substitute build metadata (git commit) in bazel builds #7378

merged 2 commits into from
Sep 30, 2021

Commits on Sep 30, 2021

  1. fix: substitute build metadata (git commit) in bazel builds 

    - Use bazel's `workspace_status_command` to report the git commit.
- Substitute it into `google::cloud::internal::build_metadata()`.
- Test that `build_metadata()` does not contain a "@" delimiter.

Fixes googleapis#4035.
    @devbww
    devbww committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    1581fdc View commit details
    Browse the repository at this point in the history

  2. Add a note about the disposition of .bazelrc when google-cloud-cpp 

    is built as part of a larger project.
    @devbww
    devbww committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    5bfefdf View commit details
    Browse the repository at this point in the history