Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): send session-refresh request at low priority #7140

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Aug 8, 2021

Use low refresh priority for the "SELECT 1" "send and forget"
session-refresh query.

Also add a note about the default transaction mode used for
that query.


This change is Reviewable

Use low refresh priority for the "SELECT 1" "send and forget"
session-refresh query.

Also add a note about the default transaction mode used for
that query.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 8, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c3a50a4ea089138c4d26880dc965ce63aa571c8a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #7140 (c3a50a4) into main (d009917) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7140   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files        1310     1310           
  Lines      113146   113147    +1     
=======================================
+ Hits       106912   106916    +4     
+ Misses       6234     6231    -3     
Impacted Files Coverage Δ
google/cloud/spanner/internal/session_pool.cc 91.25% <100.00%> (+0.03%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 97.20% <0.00%> (-0.70%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
google/cloud/storage/internal/curl_handle.h 82.85% <0.00%> (+2.85%) ⬆️
google/cloud/bigtable/internal/common_client.cc 100.00% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009917...c3a50a4. Read the comment docs.

@devbww devbww marked this pull request as ready for review August 8, 2021 21:12
@devbww devbww requested a review from a team as a code owner August 8, 2021 21:12
@devbww devbww merged commit 4cf97da into googleapis:main Aug 8, 2021
@devbww devbww deleted the session-refresh-priority branch August 8, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants