Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): timeout downloads in benchmark #7112

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 3, 2021

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d824f57d08bcdebcfb39806685e60fdab858b660

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #7112 (04380cb) into main (c2e8c7a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7112   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files        1309     1309           
  Lines      113020   113025    +5     
=======================================
+ Hits       106794   106802    +8     
+ Misses       6226     6223    -3     
Impacted Files Coverage Δ
...orage/benchmarks/aggregate_throughput_benchmark.cc 87.95% <100.00%> (+0.06%) ⬆️
...storage/benchmarks/aggregate_throughput_options.cc 100.00% <100.00%> (ø)
...ge/benchmarks/aggregate_throughput_options_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.15% <0.00%> (+1.20%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e8c7a...04380cb. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 04380cbb893d543ca119a9b05575d09917b9e52d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review August 3, 2021 23:18
@coryan coryan requested a review from a team as a code owner August 3, 2021 23:18
@coryan coryan merged commit ae0fbe6 into googleapis:main Aug 4, 2021
@coryan coryan deleted the feat-storage-set-timeout-in-benchmarks branch August 4, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants