refactor(oauth2): prepare for API key auth #14780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #14759
Move
AuthorizationHeader(...)
from a standalone function into theoauth2_internal::Credentials
class. This will allow us to return thex-goog-api-key: ...
header in the case of API key credentials.Also generalize the name to
AuthenticationHeader
, now that we are not exclusively setting theAuthorization: ...
header.Note that we cannot change any public interfaces in
google::cloud::storage::oauth2
. These are sorta-kinda public.This change is