Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): support testing with alternative endpoints #14502

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 19, 2024

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (f513220) to head (952e89e).
Report is 4 commits behind head on main.

Files Patch % Lines
.../cloud/storage/testing/storage_integration_test.cc 81.81% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14502   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2316     2316           
  Lines      207087   207100   +13     
=======================================
+ Hits       193814   193828   +14     
+ Misses      13273    13272    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 19, 2024 15:08
@coryan coryan requested review from a team as code owners July 19, 2024 15:08
@coryan coryan enabled auto-merge (squash) July 20, 2024 13:43
@coryan coryan merged commit 4c40596 into googleapis:main Jul 20, 2024
63 checks passed
@coryan coryan deleted the test-storage-support-testing-with-alternative-endpoints branch July 20, 2024 14:40
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants