Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): tweak the tag name of a FGAC sample #10266

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Nov 17, 2022

The sample specification document was ambiguous about whether one of the FGAC tag names should be plural or not. The one we chose lost the toss.


This change is Reviewable

The sample specification document was ambiguous about whether one
of the FGAC tag names should be plural or not.  The one we chose
lost the toss.
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Nov 17, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b169f6a4656987facda9e51146abf626eefee0fd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 93.84% // Head: 93.84% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b169f6a) compared to base (5046d76).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10266      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files        1554     1554              
  Lines      142815   142815              
==========================================
- Hits       134029   134028       -1     
- Misses       8786     8787       +1     
Impacted Files Coverage Δ
google/cloud/spanner/samples/samples.cc 62.24% <0.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.77% <0.00%> (+0.07%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww marked this pull request as ready for review November 17, 2022 17:46
@devbww devbww requested a review from a team as a code owner November 17, 2022 17:46
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2022

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@devbww devbww merged commit 89abc4e into googleapis:main Nov 17, 2022
@devbww devbww deleted the fine-grained-access branch November 17, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants