Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): avoid globals for easier DLLs #10212

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 9, 2022

CMake can automatically create Windows DLLs if we don't use data symbols in the library. This may unblock some folks trying to support DLLs.

Fixes #10205


This change is Reviewable

CMake can automatically create Windows DLLs if we don't use *data*
symbols in the library.  This may unblock some folks trying to support
DLLs.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c3aa4c9f50ccd3d96fc9773d82f26f4f43116933

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 93.98% // Head: 93.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c3aa4c9) compared to base (f617e71).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10212   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files        1531     1532    +1     
  Lines      141082   141084    +2     
=======================================
+ Hits       132589   132597    +8     
+ Misses       8493     8487    -6     
Impacted Files Coverage Δ
google/cloud/grpc_error_delegate.cc 93.42% <ø> (ø)
google/cloud/spanner/internal/status_utils.cc 0.00% <0.00%> (ø)
google/cloud/grpc_error_delegate_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/log_wrapper_helpers.cc 83.16% <100.00%> (ø)
google/cloud/internal/status_payload_keys.cc 100.00% <100.00%> (ø)
google/cloud/internal/status_payload_keys_test.cc 100.00% <100.00%> (ø)
google/cloud/spanner/internal/status_utils_test.cc 100.00% <100.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.83%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 9, 2022 01:23
@coryan coryan requested a review from a team as a code owner November 9, 2022 01:23
@coryan coryan merged commit 6ba8928 into googleapis:main Nov 9, 2022
@coryan coryan deleted the fix-common-avoid-globals-for-easier-DLLs branch November 9, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using global variable in google_cloud_cpp_grpc_utils breaks DLLs
3 participants