Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(storage): common initialization examples #10107

Merged
merged 2 commits into from
Oct 27, 2022
Merged

doc(storage): common initialization examples #10107

merged 2 commits into from
Oct 27, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 26, 2022 •
edited
Loading

This satisfies the most common requests for additional examples.

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 26, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 98b3017affc21603df521ad4be829675af65cec7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Base: 93.97% // Head: 93.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (89876ef) compared to base (9d6f456).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10107   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files        1513     1513           
  Lines      139964   139964           
=======================================
+ Hits       131529   131532    +3     
+ Misses       8435     8432    -3
Impacted Files Coverage Δ
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.82% <0.00%> (+0.16%) ⬆️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 27, 2022 00:00
@coryan coryan requested a review from a team as a code owner October 27, 2022 00:00
@coryan
doc(storage): common initialization examples
64a7ed5 
This satisfies the most common requests for additional examples.
@coryan coryan force-pushed the doc-storage-common-initialization-examples branch from 98b3017 to 64a7ed5 Compare October 27, 2022 02:32
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 64a7ed5ca0df3c08970a93866f8ab3879a6c11cc

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww
devbww approved these changes Oct 27, 2022
View reviewed changes
google/cloud/storage/doc/storage-main.dox

@snippet storage_client_initialization_samples.cc set-client-endpoint

## Override the authentication configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps s/Override/Overriding/ to match above, or vice versa?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@coryan coryan enabled auto-merge (squash) October 27, 2022 02:54
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 89876ef345e48424f526779b385ad5a36844ecd7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 29bf45f into googleapis:main Oct 27, 2022
@coryan coryan deleted the doc-storage-common-initialization-examples branch October 27, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @google-cloud-cpp-bot @devbww