Skip to content

Commit

Permalink
cleanup(storage): add comment on why no API key support (#14788)
Browse files Browse the repository at this point in the history
  • Loading branch information
dbolduc authored Oct 15, 2024
1 parent 80a518a commit caca34b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion google/cloud/storage/internal/unified_rest_credentials.cc
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ std::shared_ptr<oauth2::Credentials> MapCredentials(
Decorate(std::move(impl), cfg.options()));
}
void visit(internal::ApiKeyConfig const&) override {
// TODO(#14759) - Support API key authentication over REST
// Circa 2024, GCS does not support API key authentication. Moreover, we
// would have to grow the deprecated `storage::oauth2::Credentials` class
// to support setting the `x-goog-api-key` header. For these reasons, we
// just return anonymous (no-op) credentials.
result = google::cloud::storage::oauth2::CreateAnonymousCredentials();
}

Expand Down

0 comments on commit caca34b

Please sign in to comment.