changed usage-check in scripts

googleapis · Aug 2, 2019 · a50c95c · a50c95c
1 parent 6ca0d62
commit a50c95c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/bazel/compiler_id.sh b/bazel/compiler_id.sh
@@ -18,7 +18,7 @@
 # identification string for the compiler according to the CMake-defined IDs:
 # https://cmake.org/cmake/help/v3.5/variable/CMAKE_LANG_COMPILER_ID.html
 
-if [[ ! -e "${1}" ]]; then
+if [[ $# -ne 1 ]]; then
   echo "Usage: $0 <path-to-compiler>"
   exit 1
 fi

diff --git a/bazel/compiler_version.sh b/bazel/compiler_version.sh
@@ -18,9 +18,17 @@
 # the compiler's version by looking for the first string that looks like
 # X.Y with more optional numbers, '.', '-', and '+'.
 
-if [[ ! -e "${1}" ]]; then
+if [[ $# -ne 1 ]]; then
   echo "Usage: $0 <path-to-compiler>"
   exit 1
 fi
 
-"${1}" --version 2> /dev/null | grep -Eo "[0-9]+\.[0-9.+-]+" | head -1
+version="$("${1}" --version 2> /dev/null \
+  | grep -Eo "[0-9]+\.[0-9.+-]+" \
+  | head -1)"
+
+if [[ -n "${version}" ]]; then
+  echo "${version}"
+else
+  echo unknown
+fi