This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: fix racy conditions during shutdown #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 95.78% 95.81% +0.02%
==========================================
Files 101 101
Lines 4648 4657 +9
==========================================
+ Hits 4452 4462 +10
+ Misses 196 195 -1
Continue to review full report at Codecov.
|
Write a test to reproduce the problem.
We were checking if the completion queue was shutdown and then scheduling work, but not atomically.
mr-salty
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww, @devjgm, and @scotthart)
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#250) * bug: fix race condition during shutdown We were checking if the completion queue was shutdown and then scheduling work, but not atomically.
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#250) * bug: fix race condition during shutdown We were checking if the completion queue was shutdown and then scheduling work, but not atomically.
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#250) * bug: fix race condition during shutdown We were checking if the completion queue was shutdown and then scheduling work, but not atomically.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking if the completion queue was shutdown and then
scheduling work, but not atomically.
This change is