This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
feat: logging can be enabled via env var #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now enable logging to `std::clog` without any code changes or recompiling their code simply by setting the "GOOGLE_CLOUD_CPP_ENABLE_CLOG" environment variable before running their program. This env var is currently being inspected and set in some of our other code, such as https://github.com/googleapis/google-cloud-cpp-spanner/blob/20e2f9b011e3747fe5a8b8dc284245c11ff354b6/google/cloud/spanner/connection_options.cc#L68, and we should remove that after this change is merged.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 96.23% 96.23% -0.01%
==========================================
Files 97 97
Lines 4411 4406 -5
==========================================
- Hits 4245 4240 -5
Misses 166 166
Continue to review full report at Codecov.
|
devbww
approved these changes
Feb 20, 2020
coryan
pushed a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#181) Users can now enable logging to `std::clog` without any code changes or recompiling their code simply by setting the "GOOGLE_CLOUD_CPP_ENABLE_CLOG" environment variable before running their program. This env var is currently being inspected and set in some of our other code, such as https://github.com/googleapis/google-cloud-cpp-spanner/blob/20e2f9b011e3747fe5a8b8dc284245c11ff354b6/google/cloud/spanner/connection_options.cc#L68, and we should remove that after this change is merged.
coryan
pushed a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#181) Users can now enable logging to `std::clog` without any code changes or recompiling their code simply by setting the "GOOGLE_CLOUD_CPP_ENABLE_CLOG" environment variable before running their program. This env var is currently being inspected and set in some of our other code, such as https://github.com/googleapis/google-cloud-cpp-spanner/blob/20e2f9b011e3747fe5a8b8dc284245c11ff354b6/google/cloud/spanner/connection_options.cc#L68, and we should remove that after this change is merged.
coryan
pushed a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#181) Users can now enable logging to `std::clog` without any code changes or recompiling their code simply by setting the "GOOGLE_CLOUD_CPP_ENABLE_CLOG" environment variable before running their program. This env var is currently being inspected and set in some of our other code, such as https://github.com/googleapis/google-cloud-cpp-spanner/blob/20e2f9b011e3747fe5a8b8dc284245c11ff354b6/google/cloud/spanner/connection_options.cc#L68, and we should remove that after this change is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now enable logging to
std::clogwithout any code changes orrecompiling their code simply by setting the
"GOOGLE_CLOUD_CPP_ENABLE_CLOG" environment variable before running their
program.
This env var is currently being inspected and set in some of our other
code, such as
https://github.com/googleapis/google-cloud-cpp-spanner/blob/20e2f9b011e3747fe5a8b8dc284245c11ff354b6/google/cloud/spanner/connection_options.cc#L68,
and we should remove that after this change is merged.
This change is