This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
refactor: copy IsProtoEqual from spanner #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new library to host common testing utilities that depend on Protobuf, as the GCS library does not depend on protobuf and we do not want to depend on protobuf for its tests.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 96.22% 96.23% +0.01%
==========================================
Files 94 97 +3
Lines 4395 4411 +16
==========================================
+ Hits 4229 4245 +16
Misses 166 166
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 96.22% 96.23% +0.01%
==========================================
Files 94 97 +3
Lines 4395 4411 +16
==========================================
+ Hits 4229 4245 +16
Misses 166 166
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 14, 2020
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#179) Create a new library to host common testing utilities that depend on Protobuf, as the GCS library does not depend on protobuf and we do not want to depend on protobuf for its tests.
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#179) Create a new library to host common testing utilities that depend on Protobuf, as the GCS library does not depend on protobuf and we do not want to depend on protobuf for its tests.
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
…-common#179) Create a new library to host common testing utilities that depend on Protobuf, as the GCS library does not depend on protobuf and we do not want to depend on protobuf for its tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new library to host common testing utilities that depend on
Protobuf, as the GCS library does not depend on protobuf and we do not
want to depend on protobuf for its tests.
This change is