Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

chore: added v0.19.x release notes #172

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Feb 11, 2020

This change is Reviewable

@devjgm devjgm requested a review from coryan February 11, 2020 15:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2020
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devjgm)


CHANGELOG.md, line 8 at r1 (raw file):

**BREAKING CHANGES:**
* refactor!: remove grpc_utils namespace; left aliases for backward compat (#158)

I think just this message is not enough context, maybe cut&paste the commit message (with some edits) into the release notes?

**POTENTIALLY BREAKING CHANGE:** Refactor the types and functions from
`google::cloud::grpc_utils` to `google::cloud::`. The old header files
and types should continue to work, as we kept aliases for them, but
there is some risk we missed something. The library name (the physical
.a and/or .so file) is not changed, the target names for CMake are not
changed. For Bazel, the old targets continue to work, but you might want
to move to newer targets that do not expose the backwards compatibility
headers.

Up to you.

@devjgm
Copy link
Contributor Author

devjgm commented Feb 11, 2020

Yes, you're right. Of course. Updated. PTAL

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          94       94           
  Lines        4395     4395           
=======================================
  Hits         4229     4229           
  Misses        166      166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498d64d...3741c21. Read the comment docs.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional nits on the release notes, but up to you.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devjgm)


CHANGELOG.md, line 14 at r2 (raw file):

  is not changed, the target names for CMake are not changed, the target name
  for Bazel moved to the new location.

That was true for the original commit, but no longer true after the additional changes for backwards compatibility, thus my edits. Consider:

... for CMake are not changed. For Bazel, the old targets continue to work, but
you might want to move to newer targets that do not expose the backwards
compatibility headers.

Copy link
Contributor Author

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @coryan)


CHANGELOG.md, line 14 at r2 (raw file):

for CMake are not changed. For Bazel, the old targets continue to work, but
you might want to move to newer targets that do not expose the backwards
compatibility headers

Sigh. I need to read more closely. Sorry. Accepted your edits.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@devjgm devjgm merged commit 5b0fc2a into googleapis:master Feb 11, 2020
@devjgm devjgm deleted the release branch February 11, 2020 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants