Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: cancel futures returned by .then() #166

Merged
merged 1 commit into from
Feb 7, 2020
Merged

feat: cancel futures returned by .then() #166

merged 1 commit into from
Feb 7, 2020

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 7, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #166 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   95.69%   95.76%   +0.06%     
==========================================
  Files          88       88              
  Lines        4021     4059      +38     
==========================================
+ Hits         3848     3887      +39     
+ Misses        173      172       -1
Impacted Files Coverage Δ
google/cloud/internal/future_then_impl.h 100% <ø> (ø) ⬆️
google/cloud/future_generic_then_test.cc 99.19% <100%> (+0.02%) ⬆️
google/cloud/completion_queue_test.cc 94.23% <100%> (+0.64%) ⬆️
google/cloud/internal/future_impl.h 91.39% <100%> (+0.09%) ⬆️
google/cloud/completion_queue.cc 100% <100%> (ø) ⬆️
google/cloud/future_void_then_test.cc 99.58% <100%> (+0.01%) ⬆️
google/cloud/future_generic.h 100% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84fa28...a92e83f. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 7, 2020 16:25
@coryan coryan requested review from tmatsuo and mr-salty February 7, 2020 16:25
Copy link
Contributor

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tmatsuo)

@coryan coryan merged commit 946b6d3 into googleapis:master Feb 7, 2020
@coryan coryan deleted the future-then-cancel branch February 7, 2020 17:49
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants