Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

chore: simpler include guard style #144

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Jan 30, 2020

This change is Reviewable

@devjgm devjgm requested a review from coryan January 30, 2020 20:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 57 of 57 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          83       83           
  Lines        3847     3847           
=======================================
  Hits         3686     3686           
  Misses        161      161
Impacted Files Coverage Δ
google/cloud/grpc_utils/async_operation.h 100% <ø> (ø) ⬆️
google/cloud/internal/random.h 100% <ø> (ø) ⬆️
...cloud/testing_util/check_predicate_becomes_false.h 100% <ø> (ø) ⬆️
google/cloud/testing_util/chrono_literals.h 100% <ø> (ø) ⬆️
google/cloud/iam_binding.h 100% <ø> (ø) ⬆️
google/cloud/status_or.h 96.51% <ø> (ø) ⬆️
google/cloud/optional.h 97.56% <ø> (ø) ⬆️
google/cloud/testing_util/expect_future_error.h 100% <ø> (ø) ⬆️
google/cloud/internal/future_then_impl.h 100% <ø> (ø) ⬆️
google/cloud/future_generic.h 100% <ø> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2f73b...4ca92dc. Read the comment docs.

@devjgm devjgm merged commit 1992545 into googleapis:master Jan 30, 2020
@devjgm devjgm deleted the fix-include-guard branch January 30, 2020 20:26
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
coryan pushed a commit to coryan/google-cloud-cpp that referenced this pull request Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants