This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: make test not flaky #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to wait for X milliseconds on the future. We are going to block on the same future later on the test, that is really what we want to verify, that the function is called "eventually".
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 83 83
Lines 3847 3847
=======================================
Hits 3686 3686
Misses 161 161
Continue to review full report at Codecov.
|
devjgm
approved these changes
Jan 30, 2020
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
No need to wait for X milliseconds on the future. We are going to block on the same future later on the test, that is really what we want to verify, that the function is called "eventually".
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
No need to wait for X milliseconds on the future. We are going to block on the same future later on the test, that is really what we want to verify, that the function is called "eventually".
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
No need to wait for X milliseconds on the future. We are going to block on the same future later on the test, that is really what we want to verify, that the function is called "eventually".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to wait for X milliseconds on the future. We are going to block
on the same future later on the test, that is really what we want to
verify, that the function is called "eventually".
This change is