-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup.py: remove rsa requirement #942
base: main
Are you sure you want to change the base?
Conversation
2c6ceef
to
d406a4f
Compare
91f3b2c
to
39fe8ea
Compare
I think simply removing the rsa dependency will break the library since it is still in use: https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/crypt/_python_rsa.py#L28 |
Please see #646 , the code does not use python-rsa if python-cryptography is installed. |
This is still relevant because As I look at rebasing this today, I can remove the entry from |
39fe8ea
to
4894398
Compare
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
The rsa library is slower and not as well-maintained as the cryptography library. Now that we require the cryptography library, drop the hard requirement on the rsa library.
4894398
to
ed408cf
Compare
I researched kokoro to understand how to remove
The complicating factor is that I think the solution here is to release a new |
The
rsa
library is slower and not as well-maintained as thecryptography
library. Now that we require thecryptography
library, drop the hard requirement on thersa
library.Fixes: #941