build: fix system tests, move to Kokoro #372
Conversation
googlebot
added
the
cla: yes
busunkim96
force-pushed
the
use-new-nox
branch
4 times, most recently
from
058fc1d
to
84fc5f1
Compare
busunkim96
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
| python3.6 -m nox | ||
| python3.6 -m nox -f system_tests/noxfile.py |
There was a problem hiding this comment.
The system test noxfile seemed complicated enough that I didn't want to pull it into the top-level noxfile. I also experimented with having nox run nox, but there was some weirdness there.
busunkim96
force-pushed
the
use-new-nox
branch
from
820fb9b
to
c4b4f77
Compare
| "requests", | ||
| "requests-oauthlib", | ||
| "urllib3", | ||
| "cryptography", |
There was a problem hiding this comment.
Some of these seem required for the actual library to function. Those should be defined in setup.py, not here, right?
There was a problem hiding this comment.
This was a straight copy from the tox.ini. Some of them might not be needed anymore though. I'll go through and check
| @@ -1,65 +0,0 @@ | |||
| # Copyright 2016 Google Inc. | |||
There was a problem hiding this comment.
Is it intended to delete this file? How are we system testing user-based credentials files?
There was a problem hiding this comment.
The removal of scripts/obtain_user_auth.py was intentional. The current script uses oauth2client to make the credentials. I added instructions on how to get the credentials using gcloud in the 'Running system tests' section of the CONTRIBUTING.rst.
You can ignore changes to source code and test files in
google/andtests/, they are the result of running black.