New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add urllib3 AuthorizedHttp #19

Merged

theacodes merged 4 commits into master from urllib3-authorized-http

Oct 13, 2016

Contributor

theacodes commented Oct 12, 2016

Implementation of the plan detailed over at #15.

theacodes added this to the 1.0.0 milestone

theacodes assigned bjwatson and dhermes


          Add urllib3 AuthorizedHttp

624fa02

theacodes force-pushed the urllib3-authorized-http branch from 965389b to 624fa02 Compare

October 12, 2016 22:05

dhermes reviewed

View reviewed changes

google/auth/transport/__init__.py

+              from six.moves import http_client
+              DEFAULT_REFRESH_STATUS_CODES = (http_client.UNAUTHORIZED,)
+              DEFAULT_MAX_REFRESH_ATTEMPTS = 2

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/transport/urllib3.py

+              try:
+                  import certifi
+              except ImportError:  # pragma: NO COVER
+                  certifi = None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/transport/urllib3.py

+                      http = urllib3.PoolManager()
+                      request = google.auth.transport.urllib3.Request(http)
+                      credentials.refresh(request)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/transport/urllib3.py



		def _make_default_http():
		if certifi:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/transport/urllib3.py

+                  if certifi:
+                      return urllib3.PoolManager(
+                          cert_reqs='CERT_REQUIRED',
+                          ca_certs=certifi.where())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/transport/test_urllib3.py

+                      self.headers = headers or {}
+                  def urlopen(self, method, url, body=None, headers=None, **kwargs):
+                      self.requests.append((method, url, body, headers))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/transport/test_urllib3.py

		return self.responses.pop(0)


		class MockResponse(object):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/transport/test_urllib3.py

+                          mock.sentinel.credentials)
+                      assert authed_http.credentials == mock.sentinel.credentials
+                      assert authed_http.http is not None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/transport/test_urllib3.py

+                      assert authed_http.http is not None
+                  def test_urlopen_no_refresh(self):
+                      mock_credentials = mock.Mock(wraps=MockCredentials())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/transport/test_urllib3.py

+                  def test_urlopen_refresh(self):
+                      mock_credentials = mock.Mock(wraps=MockCredentials())
+                      mock_final_response = MockResponse(status=http_client.OK)
+                      # First request will 403, second request will succeed.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

theacodes added 3 commits

October 12, 2016 20:24


          Address review comments

d95e176


          Address review comments

9ba025e


          Track kwargs in requests

b7a2111

Contributor

dhermes commented Oct 13, 2016

@jonparrott We have anything left?

Contributor Author

theacodes commented Oct 13, 2016

Don't think so.

On Wed, Oct 12, 2016, 10:46 PM Danny Hermes [email protected]
wrote:

@jonparrott https://github.com/jonparrott We have anything left?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc8mIfZ4OLMoPGnPioce6t7ufaTF7ks5qzcWsgaJpZM4KVNbu
.

Contributor

dhermes commented Oct 13, 2016

👍 LGTM then

theacodes merged commit 27f6e1e into master

theacodes deleted the urllib3-authorized-http branch

October 13, 2016 16:46

theacodes unassigned bjwatson and dhermes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet