Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose id_token in OAuth 2.0 credentials #150

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Expose id_token in OAuth 2.0 credentials #150

merged 4 commits into from
Mar 28, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #149

@theacodes theacodes added this to the 1.0.0 milestone Mar 27, 2017
dhermes
dhermes reviewed Mar 28, 2017
View reviewed changes
google/oauth2/credentials.py Outdated
@@ -90,6 +91,17 @@ def client_secret(self):
return self._client_secret

@property
def refresh_grant_response(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/oauth2/service_account.py Outdated
@@ -306,10 +319,11 @@ def _make_authorization_grant_assertion(self):
@_helpers.copy_docstring(credentials.Credentials)
def refresh(self, request):
assertion = self._make_authorization_grant_assertion()
access_token, expiry, _ = _client.jwt_grant(
access_token, expiry, refresh_grant_response = _client.jwt_grant(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes changed the title Expose the refresh grant response in OAuth 2.0 credentials Expose id_token in OAuth 2.0 credentials Mar 28, 2017
@theacodes
Copy link
Contributor Author

@dhermes updated. PTAL.

dhermes
dhermes reviewed Mar 28, 2017
View reviewed changes
google/oauth2/credentials.py Outdated
self._scopes = scopes
self._token_uri = token_uri
self._client_id = client_id
self._client_secret = client_secret
self._refresh_grant_response = None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/oauth2/credentials.py Outdated

self.token = access_token
self.expiry = expiry
self._refresh_token = refresh_token
self._id_token = grant_response.get('id_token', self._id_token)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit 26a1637 into master Mar 28, 2017
@theacodes theacodes deleted the token-response branch March 28, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @dhermes