feat: Use float instead of int for GCE_METADATA_TIMEOUT #1481
Conversation
Move the logic to read GCE_METADATA_TIMEOUT env variable so we can better control it in app_identity component. Related internal change is 607513254.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
The change LGTM |
ludoch
changed the title
clundin25
changed the title
| except ValueError: # pragma: NO COVER | ||
| pass |
There was a problem hiding this comment.
I would not capture a ValueError here. Additionally, the timeout variable would not be usable, so the downstream call would have problems.
There was a problem hiding this comment.
FWIW the original code caught the ValueError. The value is set by the user.
I am thinking if the Exception happens timeout will retain the passed in/default value
There was a problem hiding this comment.
In that case, can you remove the pragma, and include test coverage for this change?
* Add a test with new _metadata.py changes * Add tests for metadata changes.
* chore(python): update dependencies in /.kokoro (googleapis#1499) Source-Link: googleapis/synthtool@db94845 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a8a80fc6456e433df53fc2a0d72ca0345db0ddefb409f1b75b118dfd1babd952 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]> * Add a test with new _metadata.py changes * Add tests for metadata changes. * chore(python): bump idna from 3.4 to 3.7 in .kokoro (googleapis#1517) Source-Link: googleapis/synthtool@d50980e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5a4c19d17e597b92d786e569be101e636c9c2817731f80a5adec56b2aa8fe070 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]> * Update environment_vars.py --------- Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
Move the logic to read GCE_METADATA_TIMEOUT env variable so we can better control it in app_identity component.
Related internal change is 607513254.