Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add deprecation notice for 3.7. #1371

Merged
merged 5 commits into from
Oct 23, 2023
Merged

chore: Add deprecation notice for 3.7. #1371

merged 5 commits into from
Oct 23, 2023

Conversation

clundin25
Copy link
Contributor

No description provided.

@clundin25 clundin25 requested review from a team as code owners August 16, 2023 17:51
@clundin25 clundin25 changed the title chore: Add deprecation notice for 3.6 and 3.7. chore: Add deprecation notice for 3.7. Aug 16, 2023
@arithmetic1728
Copy link
Contributor

it seems some unit test is needed to cover the new changes

@clundin25
Copy link
Contributor Author

it seems some unit test is needed to cover the new changes

Good catch, I'll add those

@clundin25 clundin25 force-pushed the deprecation-notice-3.7 branch from d0b056c to 217c01d Compare September 7, 2023 18:26
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@arithmetic1728 arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2023
@arithmetic1728
Copy link
Contributor

gcloud will drop 3.7 on sep 26, let's hold on until then

@clundin25
Copy link
Contributor Author

@arithmetic1728 sounds good 👍

@clundin25
Copy link
Contributor Author

@arithmetic1728 I am okay with waiting but I think this change is still safe, it is just a deprecation notice that would impact some users

@arithmetic1728 arithmetic1728 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 23, 2023
@clundin25 clundin25 force-pushed the deprecation-notice-3.7 branch from 97d71e8 to f3ddead Compare October 23, 2023 22:10
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2023
@clundin25 clundin25 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 15f330e into googleapis:main Oct 23, 2023
4 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 23, 2023
@holtskinner holtskinner mentioned this pull request Nov 29, 2023
Closed
@artgromov artgromov mentioned this pull request Dec 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clundin25 @arithmetic1728