Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove support for Python 3.6 #1354

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Conversation

clundin25
Copy link
Contributor

@clundin25 clundin25 commented Jul 20, 2023

No urgency to merge this, but I do want to use some features from Python 3.7.

3.6 has been EOL for sometime, and the core library has dropped support https://github.com/googleapis/python-api-core.

@clundin25 clundin25 requested review from a team as code owners July 20, 2023 10:37
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023
@parthea
Copy link
Contributor

parthea commented Jul 21, 2023

Python 3.7 is also unsupported in the python community. https://devguide.python.org/versions/#unsupported-versions . I'd recommend dropping both at the same time. Could we consider raising a deprecation warning in the next month notifying users that support for both 3.6 and 3.7 will be dropped on a specific date? We have a similar proposal in google-cloud-python which will be sent for review soon: googleapis/google-cloud-python#11437

Only users who are running the latest version of google-auth, using runtime versions which are unsupported, would receive the warnings, and the warning should only appear once per session. For example, users running python 3.8+ won't see any warnings.

If we have Google projects requiring python 3.7, then let's work together to figure out an acceptable date when support can be dropped across these project and communicate the date in advance via the README (and potentially also through deprecation warnings).

Please file an issue in this repo if you would consider adding a feature to raise a deprecation warning before dropping a language runtime and we can continue the discussion in the issue.

@clundin25
Copy link
Contributor Author

Historically I think gcloud has been the main reason to keep older versions, but now that we only support Python3 it might be easier to move faster.

Could we write a document that describes what versions we support and for how long? That might scale better than adding deprecations. Something akin to Go's version policy.

@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@clundin25 clundin25 requested a review from a team as a code owner August 21, 2023 22:26
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@BigTailWolf BigTailWolf merged commit 117e325 into googleapis:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants