-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding meta header for trust boundary #1334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsirac
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 13, 2023
aeitzman
reviewed
Jun 20, 2023
BigTailWolf
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 26, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 26, 2023
arithmetic1728
approved these changes
Jun 28, 2023
aeitzman
approved these changes
Jun 28, 2023
lsirac
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 28, 2023
lsirac
approved these changes
Jun 28, 2023
BigTailWolf
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 29, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most base class
google.auth.credentials.Credentials
, expose a field_trust_boundary
default toNone
.During the
before_request
. Apply the value toX-Identity-Trust-Boundary
field if it's notNone
.For planned credential types (service account and 3PI credentials)
google.oauth2.service_account.Credentials
andgoogle.auth.external_account.Credentials
. We inject an empty string value in constructor in order to have that field to be exposed duringbefore_request
.