Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding meta header for trust boundary #1334

Merged
merged 11 commits into from
Jun 29, 2023

Conversation

BigTailWolf
Copy link
Contributor

For most base class google.auth.credentials.Credentials, expose a field _trust_boundary default to None.
During the before_request. Apply the value to X-Identity-Trust-Boundary field if it's not None.

For planned credential types (service account and 3PI credentials) google.oauth2.service_account.Credentials and google.auth.external_account.Credentials. We inject an empty string value in constructor in order to have that field to be exposed during before_request.

@BigTailWolf BigTailWolf requested review from a team as code owners June 13, 2023 22:37
@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 13, 2023
google/auth/external_account.py Show resolved Hide resolved
google/auth/external_account.py Outdated Show resolved Hide resolved
google/auth/credentials.py Outdated Show resolved Hide resolved
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2023
@lsirac lsirac removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 28, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2023
@BigTailWolf BigTailWolf merged commit 908c8d1 into googleapis:main Jun 29, 2023
@BigTailWolf BigTailWolf deleted the b286458865 branch June 29, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants