Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a file system cache class #571

Merged
merged 14 commits into from
Aug 22, 2024
Merged

feat: Add a file system cache class #571

merged 14 commits into from
Aug 22, 2024

Conversation

Hectorhammett
Copy link
Contributor

@Hectorhammett Hectorhammett commented Aug 13, 2024

Add a PSR-6 compliant FileSystemCacheItemPool class for easy configuration fixing some issues with caching in memory as PHP handles requests in different processes. This show alleviate this issue.

closes #498

@Hectorhammett Hectorhammett changed the title Add a file system cache class feat: Add a file system cache class Aug 13, 2024
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass - looks really good!

src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
tests/Cache/FileSystemCacheItemPoolTest.php Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett requested a review from bshaffer August 19, 2024 19:17
README.md Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
tests/Cache/FileSystemCacheItemPoolTest.php Outdated Show resolved Hide resolved
tests/Cache/FileSystemCacheItemPoolTest.php Outdated Show resolved Hide resolved
tests/Cache/FileSystemCacheItemPoolTest.php Outdated Show resolved Hide resolved
tests/Cache/FileSystemCacheItemPoolTest.php Outdated Show resolved Hide resolved
src/Cache/FileSystemCacheItemPool.php Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett marked this pull request as ready for review August 21, 2024 22:02
@Hectorhammett Hectorhammett requested a review from a team as a code owner August 21, 2024 22:02
README.md Outdated Show resolved Hide resolved
@Hectorhammett Hectorhammett merged commit 8555cb0 into main Aug 22, 2024
12 checks passed
@Hectorhammett Hectorhammett deleted the caching branch August 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default file caching
2 participants