Suggestions: Metrics with trait suggestions #512
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for #509
Major changes:
getMetricHeader
for simplicity, and removeapplyHeaders
FetchAuthTokenCache
when a cached token is found (rather than inCredentialsLoader
)Minor changes
$credType
a constant and addgetCredType
method to each Credential (and toUpdateMetadataInterface
)$metricsHeaderKey
a constant and move it toUpdateMetadataInterface::METRIC_METADATA_KEY
(to be consistent withAUTH_METADATA_KEY
)$metricsHeaders
parameters to$headers
, as this is more accurate.MetricsTrait
inUpdateMetadataTrait
(since it depends on this)getVersion
private