Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TypedItem to allow for psr/cache:3 #364

Merged
merged 9 commits into from
Apr 11, 2022
Merged

feat: add TypedItem to allow for psr/cache:3 #364

merged 9 commits into from
Apr 11, 2022

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 24, 2021 •
edited
Loading

Supports psr/cache:3.0 and addresses #363

This PR raises the minimum version supported to PHP 7.1 and adds return types to SysvCacheItemPool and MemoryCacheItemPool

This change will break BC for anyone extending SysvCacheItemPool, but I imagine this is a very unlikely scenario.

@bshaffer bshaffer requested a review from a team as a code owner September 24, 2021 18:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@bshaffer bshaffer mentioned this pull request Sep 24, 2021
Closed
Geolim4
Geolim4 reviewed Sep 25, 2021
View reviewed changes
tests/BaseTest.php Show resolved Hide resolved
src/Cache/TypedItem.php Show resolved Hide resolved
src/Cache/TypedItem.php Show resolved Hide resolved
src/Cache/TypedItem.php Outdated Show resolved Hide resolved
@Geolim4 Geolim4 mentioned this pull request Sep 27, 2021
Merged
6 tasks
@wlasnapl wlasnapl mentioned this pull request Feb 18, 2022
Closed
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 23, 2022
@bshaffer bshaffer mentioned this pull request Mar 24, 2022
Closed
@bshaffer bshaffer force-pushed the add-typed-cache-item branch from 596ec7e to 7365613 Compare March 24, 2022 22:00
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 24, 2022
@bshaffer bshaffer mentioned this pull request Apr 4, 2022
Closed
noahdietz
noahdietz reviewed Apr 5, 2022
View reviewed changes
Copy link

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from my phone lol

src/Cache/MemoryCacheItemPool.php Outdated Show resolved Hide resolved
src/Cache/SysVCacheItemPool.php Outdated Show resolved Hide resolved
noahdietz
noahdietz approved these changes Apr 6, 2022
View reviewed changes
Copy link

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will Approve, but perhaps double check with @dwsupplee that the BC is OK? Feel like I'm still learning a bit in these repos.

src/Cache/MemoryCacheItemPool.php Show resolved Hide resolved
dwsupplee
dwsupplee suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the surface for the BC break is small enough to warrant the support here 👍 , LGTM with a few minor notes.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
src/Cache/MemoryCacheItemPool.php Show resolved Hide resolved
src/Cache/TypedItem.php Outdated Show resolved Hide resolved
src/Cache/TypedItem.php Show resolved Hide resolved
@bshaffer
Copy link
Contributor Author

bshaffer commented Apr 9, 2022

@dwsupplee all done here!

@bshaffer bshaffer merged commit 321e5b6 into main Apr 11, 2022
@bshaffer bshaffer deleted the add-typed-cache-item branch April 11, 2022 19:01
@Geolim4
Copy link

Geolim4 commented Apr 11, 2022

Alleluia 🥳

Thank you to all participants.

@bshaffer
Copy link
Contributor Author

This is now released in v1.20.0

@bshaffer bshaffer mentioned this pull request Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lustmored Lustmored Lustmored left review comments

@Geolim4 Geolim4 Geolim4 left review comments

@noahdietz noahdietz noahdietz approved these changes

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bshaffer @Geolim4 @dwsupplee @Lustmored @noahdietz