Fix logic for disabling logging

googleapis · Sep 20, 2024 · ac4d686 · ac4d686
1 parent 7e76353
commit ac4d686
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/HttpHandler/Guzzle6HttpHandler.php b/src/HttpHandler/Guzzle6HttpHandler.php
@@ -33,7 +33,7 @@ class Guzzle6HttpHandler
     private $client;
 
     /**
-     * @var LoggerInterface
+     * @var null|LoggerInterface
      */
     private $logger;
 

diff --git a/src/HttpHandler/HttpHandlerFactory.php b/src/HttpHandler/HttpHandlerFactory.php
@@ -52,7 +52,9 @@ public static function build(
             $client = new Client(['handler' => $stack]);
         }
 
-        if ($logger !== false) {
+        if ($logger === false) {
+            $logger = null;
+        } else {
             $logger = $logger ?? ApplicationDefaultCredentials::getDefaultLogger();
         }