-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from GAPI to gtoken + Bug Fix #20
Conversation
UserRefreshClient.super_.prototype.refereshToken_.call(this._refreshToken, | ||
opt_callback); | ||
UserRefreshClient.super_.prototype.refreshToken_.call( | ||
this, this._refreshToken, opt_callback); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
assert.equal('http://foo', opts.scope); | ||
done(); | ||
return { | ||
getToken: function() {} | ||
} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Switch from GAPI to gtoken + Bug Fix
Thanks @tbetbetbe. What's the timeline for getting a new npm version out with these changes? |
There should be a release at the end of this week. On 27 March 2015 at 11:22, Ryan Seys [email protected] wrote:
This email may be confidential or privileged. If you received this |
Done. I just released 0.9.4. On 30 March 2015 at 08:58, Tim Emiola [email protected] wrote:
This email may be confidential or privileged. If you received this |
I switched the library to use gtoken to add support for a path to a p12 keyfile. It's also a more well maintained and documented codebase (and made by the one and only @ryanseys).
I also caught a couple of bugs, which I will point out with comments.
(RE: googleapis/google-cloud-node#458)