Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#228 update default metadata url #230

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fix#228 update default metadata url #230

merged 1 commit into from
Mar 25, 2019

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Mar 8, 2019

Fixes #228

@ajaaym ajaaym requested a review from a team as a code owner March 8, 2019 15:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@44a5d33). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #230   +/-   ##
=========================================
  Coverage          ?   78.26%           
  Complexity        ?      329           
=========================================
  Files             ?       21           
  Lines             ?     1445           
  Branches          ?      158           
=========================================
  Hits              ?     1131           
  Misses            ?      236           
  Partials          ?       78
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 86.23% <ø> (ø) 31 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5d33...ad6746d. Read the comment docs.

sduskis
sduskis reviewed Mar 8, 2019
View reviewed changes
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
@@ -71,7 +71,7 @@
private static final Logger LOGGER = Logger.getLogger(ComputeEngineCredentials.class.getName());

// Note: the explicit IP address is used to avoid name server resolution issues.
static final String DEFAULT_METADATA_SERVER_URL = "http://169.254.169.254";
static final String DEFAULT_METADATA_SERVER_URL = "http://metadata.google.internal";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use metadata.google.internal. with the . at the end. We need that to solve a nasty problem in docker related to that problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this issue #4269 and its fixed with http://metadata.google.internal for GKE and GCE both.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 15, 2019
@sduskis sduskis merged commit 4c8360e into googleapis:master Mar 25, 2019
@JesseLovelace JesseLovelace mentioned this pull request Mar 25, 2019
Merged
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultCredentialsProvider is broken for java8 app engine
4 participants
@ajaaym @sduskis @googlebot @yoshi-automation