Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure new redirect_uri propogates to OAuth2 class #2282

Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: ensure new redirect_uri propogates to OAuth2 class #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae827f
fix: ensure new redirect_uri propogates to OAuth2 class
bshaffer Jun 16, 2022
3671de4
add a test
bshaffer Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ public function createAuthUrl($scope = null)
'login_hint' => $this->config['login_hint'],
'openid.realm' => $this->config['openid.realm'],
'prompt' => $this->config['prompt'],
'redirect_uri' => $this->config['redirect_uri'],
'response_type' => 'code',
'scope' => $scope,
'state' => $this->config['state'],
Expand Down
16 changes: 16 additions & 0 deletions tests/Google/ClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,4 +1015,20 @@ public function testCredentialsOptionWithCredentialsLoader()
$this->assertNotNull($authHeader);
$this->assertEquals('Bearer abc', $authHeader);
}

public function testSetNewRedirectUri()
{
$client = new Client();
$redirectUri1 = 'https://foo.com/test1';
$client->setRedirectUri($redirectUri1);

$authUrl1 = $client->createAuthUrl();
$this->assertStringContainsString(urlencode($redirectUri1), $authUrl1);

$redirectUri2 = 'https://foo.com/test2';
$client->setRedirectUri($redirectUri2);

$authUrl2 = $client->createAuthUrl();
$this->assertStringContainsString(urlencode($redirectUri2), $authUrl2);
}
}