-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests against PHP 7.3+ and check for cross-version support for PHP 5.4+ #1684
Run tests against PHP 7.3+ and check for cross-version support for PHP 5.4+ #1684
Conversation
Thanks @swissspidy, the proposal makes a lot of sense! We'll need to address the failing tests, but once that gets ironed out I'm good with this. |
Thanks @jdpedrie! Not sure why the tests fail on PHP 5.4 though 🤔 |
Prevents downgrading dev dependencies
Working smoothly now! 🎉 |
BTW I also might have a small change ready that could help with the PHP 7.4 failures. Basically, it would run tests on that platform using a newer version of PHPUnit. |
Looks good to me. Will |
In my experience the snapshot builds on Travis would then just be for the 7.4.x alphas. Because for PHP 8 there is the |
So once we get to release, we'll need to be sure to update this to |
Ideally, yes :-) |
No description provided.