Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against PHP 7.3+ and check for cross-version support for PHP 5.4+ #1684

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Run tests against PHP 7.3+ and check for cross-version support for PHP 5.4+ #1684

merged 5 commits into from
Jul 31, 2019

Conversation

swissspidy
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2019
@jdpedrie
Copy link
Contributor

Thanks @swissspidy, the proposal makes a lot of sense! We'll need to address the failing tests, but once that gets ironed out I'm good with this.

@swissspidy
Copy link
Contributor Author

Thanks @jdpedrie! Not sure why the tests fail on PHP 5.4 though 🤔
I suppose it's because of different versions of packages being used. Any hint appreciated.

@swissspidy
Copy link
Contributor Author

Working smoothly now! 🎉

@swissspidy
Copy link
Contributor Author

BTW I also might have a small change ready that could help with the PHP 7.4 failures. Basically, it would run tests on that platform using a newer version of PHPUnit.

@jdpedrie
Copy link
Contributor

Looks good to me. Will 7.4snapshot still be available once 7.4 is officially released?

@swissspidy
Copy link
Contributor Author

In my experience the snapshot builds on Travis would then just be for the 7.4.x alphas. Because for PHP 8 there is the nightly version.

@jdpedrie
Copy link
Contributor

So once we get to release, we'll need to be sure to update this to 7.4.

@swissspidy
Copy link
Contributor Author

Ideally, yes :-)

@jdpedrie jdpedrie merged commit 7826dd0 into googleapis:master Jul 31, 2019
@swissspidy swissspidy deleted the add/php-compatibility-sniffs branch July 31, 2019 18:36
@jdpedrie jdpedrie mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants