build: run codegen from GitHub actions #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
force-pushed
the
gha-codegen
branch
2 times, most recently
from
4e8dd4b to
5c08ba7
Compare
chingor13
force-pushed
the
gha-codegen
branch
from
5c08ba7 to
dab7075
Compare
bshaffer
reviewed
Feb 23, 2022
.github/workflows/codegen.yml
Outdated
| python-version: 2.7 | ||
| - id: find-preferred-versions | ||
| run: | | ||
| versions=$( cat discovery-artifact-manager/discoveries/index.json | jq -r '[.items[] | select(.name == "${{ matrix.service }}" and .name != "discovery" and .name != "websecurityscanner") | select(.name == "admin" or .preferred).version] | join(",")' ) |
There was a problem hiding this comment.
Can we either clean this logic up to make it more readable, or define the logic elsewhere?
Also, I don't think this really needs to be here... can't we ensure "discovery" and "websecurityscanner" don't show up in matrix.service instead?
select(.name == "${{ matrix.service }}" and .name != "discovery" and .name != "websecurityscanner") |
If not, we can add a different step to exclude them, such as:
if: ${{ matrix.service != "discovery" and matrix.service != "websecurityscanner" }}
There was a problem hiding this comment.
I can't update the initial list (it's a shared external workflow that lists all the available services), but I should be able to exclude separately via a matrix exclusion or a separate if clause.
tmatsuo
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches codegen to per-service PRs created via GitHub actions. Codegen is started nightly.
Example: chingor13#3