-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3822: Added contentOffset to MediaHttpUploader #1219
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@andrey-qlogic, can you please sign the CLA? |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
@andrey-qlogic signed the CLA, but didn't comment with "I signed it!" |
I signed it! |
@andrey-qlogic, does this fix an issue? If so can, you please add the issue |
google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java
Outdated
Show resolved
Hide resolved
CLAs look good, thanks! |
@chingor13 thanks for review, the good point about -1 value. |
@chingor13 The comment fixed: Don't add contentOffset when it -1 |
Closing this as googleapis/google-cloud-java/issues/3822 was fixed by googleapis/google-cloud-java/pull/4170 |
and AbstractGoogleClientRequest.
Fixes googleapis/google-cloud-java#3822 (it's a good idea to open an issue first for discussion)