Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generated method class calls parent's initialize method #20944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented May 7, 2024

No description provided.

@lqiu96 lqiu96 requested review from blakeli0 and meltsufin May 7, 2024 16:04
@lqiu96 lqiu96 requested a review from a team as a code owner May 7, 2024 16:04
@blakeli0 blakeli0 added automerge Merge the pull request once unit tests and other checks pass. do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed automerge Merge the pull request once unit tests and other checks pass. labels May 7, 2024
@blakeli0
Copy link
Contributor

blakeli0 commented May 7, 2024

This fix is not urgently needed anymore since we removed contentwarehouse. The fix could still be valid, but since this is a template change, let's do more investigation to make sure it has no impact on all the existing libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants