refactor: adapt code to get ready for adding logging #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codyoss
commented
Dec 12, 2024
•
codyoss
commented
- fix some deprecation warnings
- have bodys return as the type they are: bytes.Buffer
- add new handle to return a bytes.Buffer instead of Reader
- fix some deprecation warnings - have bodys return as the type they, a bytes.Buffer - add new handle to return a bytes.Buffer instead of Reader
codyoss
changed the title
codyoss
added
the
do not merge
codyoss
removed
the
do not merge
quartzmo
reviewed
Dec 12, 2024
quartzmo
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.