feat: Async refresh dry run in parallel with sync refresh #2849
Conversation
bhshkh
changed the title
| // module should asynchronously refresh auth token in parallel to sync refresh | ||
| // | ||
| // errHandler function will be called when there is an error while refreshing | ||
| // the token asynchronously |
There was a problem hiding this comment.
What should the errHandler function do? Log the error?
There was a problem hiding this comment.
No specific requirement on that. User can do whatever they need to
|
Can this change be made upstream instead with an embedded private option: https://pkg.go.dev/google.golang.org/api/option/internaloption#EmbeddableAdapter |
No. the token refresh code is deep into this library and not Bigtable. |
| // | ||
| // This is an EXPERIMENTAL option and will be removed in the future. | ||
| // TODO(b/372244283): Remove after b/358175516 has been fixed | ||
| func EnableAsyncRefreshDryRun(errHandler func()) option.ClientOption { |
There was a problem hiding this comment.
Is there any annotation to mark this as internal api?
| @@ -298,8 +332,14 @@ func dial(ctx context.Context, insecure bool, o *internal.DialSettings) (*grpc.C | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| ts := creds.TokenSource | |||
There was a problem hiding this comment.
This code will not be hit if the new auth lib is enabled. That that intentional here?
Internal bug : b/372244283
This is being used in Bigtable client
googleapis/google-cloud-go#11066