fix(transport): enforce 1s timeout on requests to MDS universe_domain #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Temporarily return googleapis.com on MDS universe_domain timeout. closes: googleapis/google-cloud-go#9350
codyoss
requested changes
Feb 5, 2024
…artzmo/google-api-go-client into transport-get-universe-domain-timeout
codyoss
reviewed
Feb 5, 2024
internal/settings.go
Outdated
| } | ||
| return credsUniverseDomain, nil | ||
|
|
||
| loop: |
There was a problem hiding this comment.
This can all be simplified a bit. You should be able to use a single select without a loop. The select will wait until one of the channels returns a result.
viacheslav-rostovtsev
approved these changes
Feb 5, 2024
codyoss
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: googleapis/google-cloud-go#9350