Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add universe domain support #2296

Merged
merged 28 commits into from
Jan 18, 2024
Merged

feat: add universe domain support #2296

merged 28 commits into from
Jan 18, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Dec 8, 2023

Alternative implementation of #2284.

shollyman
shollyman reviewed Dec 11, 2023
View reviewed changes
internal/cba.go Outdated Show resolved Hide resolved
internal/settings.go Outdated Show resolved Hide resolved
@quartzmo quartzmo mentioned this pull request Jan 17, 2024
Merged
@quartzmo quartzmo marked this pull request as ready for review January 17, 2024 21:59
@quartzmo quartzmo requested review from yoshi-approver and a team as code owners January 17, 2024 21:59
@quartzmo quartzmo mentioned this pull request Jan 17, 2024
Closed
shollyman
shollyman reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, but overall looks like it's in good shape.

impersonate/user.go Outdated Show resolved Hide resolved
internal/cba.go Outdated Show resolved Hide resolved
internal/cba_test.go Show resolved Hide resolved
internal/creds_test.go Show resolved Hide resolved
codyoss
codyoss reviewed Jan 18, 2024
View reviewed changes
impersonate/impersonate.go Outdated Show resolved Hide resolved
internal/cba.go Outdated Show resolved Hide resolved
internal/settings.go Outdated Show resolved Hide resolved
@quartzmo quartzmo merged commit 6ef1144 into googleapis:main Jan 18, 2024
5 checks passed
@release-please release-please bot mentioned this pull request Jan 18, 2024
Merged
@quartzmo quartzmo mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@codyoss codyoss codyoss approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quartzmo @shollyman @codyoss